refactor(seeders): decouple user creation from RolePermissionSeeder to maintain single responsibility

This commit is contained in:
Ray1111-aa
2026-10-22 11:58:34 +07:00
parent d14409a566
commit 4b0a438476
3 changed files with 17 additions and 22 deletions
+1 -20
View File
@@ -4,7 +4,6 @@ namespace Database\Seeders;
use App\Models\User;
use Illuminate\Database\Seeder;
use Illuminate\Support\Facades\Hash;
use Spatie\Permission\Models\Permission;
use Spatie\Permission\Models\Role;
use Spatie\Permission\PermissionRegistrar;
@@ -78,25 +77,7 @@ class RolePermissionSeeder extends Seeder
$role->syncPermissions($perms);
}
// 4. Buat Akun Default Super Admin (Murni dibaca dari config/auth.php & .env)
$superAdminConfig = config('auth.superadmin');
if ($superAdminConfig && !empty($superAdminConfig['username']) && !empty($superAdminConfig['password'])) {
$superAdmin = User::firstOrCreate(
['username' => $superAdminConfig['username']],
[
'name' => $superAdminConfig['name'] ?? 'Super Administrator',
'email' => $superAdminConfig['email'] ?? '[email protected]',
'password' => Hash::make($superAdminConfig['password']),
'role' => 'super_admin',
]
);
if (!$superAdmin->hasRole('super_admin')) {
$superAdmin->assignRole('super_admin');
}
}
// 5. Sinkronisasi Akun Existing ke Spatie Roles
// 4. Sinkronisasi Akun Existing ke Spatie Roles (jika sebelumnya sudah ada akun di DB)
$existingUsers = User::all();
foreach ($existingUsers as $user) {
if ($user->role && in_array($user->role, array_keys($rolesWithPermissions))) {
+2 -2
View File
@@ -45,7 +45,7 @@ class AuthenticationTest extends TestCase
$user = auth()->user();
$this->assertEquals('1185', $user->username);
$this->assertEquals('Mima', $user->name);
$this->assertEquals(config('auth.hse_admin.name', 'Mima'), $user->name);
$this->assertEquals('hse_admin', $user->role);
}
@@ -64,7 +64,7 @@ class AuthenticationTest extends TestCase
$user = auth()->user();
$this->assertEquals('1171', $user->username);
$this->assertEquals('Pinto Yuliandra', $user->name);
$this->assertEquals(config('auth.qma_admin.name', 'Pinto Yuliandra'), $user->name);
$this->assertEquals('qma_admin', $user->role);
}
+14
View File
@@ -22,6 +22,20 @@ abstract class TestCase extends BaseTestCase
if (Schema::hasTable('permissions') && \Spatie\Permission\Models\Permission::count() === 0) {
$this->seed(RolePermissionSeeder::class);
}
if (Schema::hasTable('users') && User::where('username', 'superadmin')->count() === 0) {
$superAdmin = User::firstOrCreate([
'username' => config('auth.superadmin.username', 'superadmin'),
], [
'name' => config('auth.superadmin.name', 'Super Administrator'),
'email' => config('auth.superadmin.email', '[email protected]'),
'password' => Hash::make(config('auth.superadmin.password', 'password')),
'role' => 'super_admin',
]);
if (!$superAdmin->hasRole('super_admin')) {
$superAdmin->assignRole('super_admin');
}
}
}
/**