security(core): patch driver IDOR, protect employee core role, harden XLSX parser, and fix timesheet concurrency race condition

This commit is contained in:
Ray1111-aa
2026-10-28 15:37:01 +07:00
parent 48678df82b
commit 1e1286e3e2
9 changed files with 155 additions and 32 deletions
@@ -101,7 +101,7 @@ class RolePermissionController extends Controller
$role = Role::findOrFail($roleId);
// Proteksi role inti sistem
$coreRoles = ['super_admin', 'hse_admin', 'qma_admin', 'pg_admin', 'gate_officer'];
$coreRoles = ['super_admin', 'hse_admin', 'qma_admin', 'pg_admin', 'gate_officer', 'employee'];
if (in_array($role->name, $coreRoles)) {
return redirect()->route('admin.roles.index')
->with('error', "Aksi Ditolak: Role inti sistem [{$role->name}] tidak dapat dihapus.");
@@ -163,17 +163,13 @@ class GateInspectionController extends Controller
$guardId = $request->input('security_guard_id') ?? ($currentGuard ? $currentGuard->id : null);
if (!$guardId) {
$fallbackGuard = SecurityGuard::where('is_active', true)->first() ?? SecurityGuard::first();
if ($fallbackGuard) {
$guardId = $fallbackGuard->id;
} else {
$request->validate([
'security_guard_id' => ['required', 'exists:security_guards,id'],
], [
'security_guard_id.required' => 'Silakan pilih nama petugas Satpam yang melakukan pemeriksaan.',
]);
$guardId = $request->input('security_guard_id');
}
$request->validate([
'security_guard_id' => ['required', 'exists:security_guards,id'],
], [
'security_guard_id.required' => 'Silakan pilih nama petugas Satpam yang melakukan pemeriksaan fisik.',
'security_guard_id.exists' => 'Petugas Satpam yang dipilih tidak valid dalam sistem.',
]);
$guardId = $request->input('security_guard_id');
}
$activity = VehicleActivity::with(['vehicle', 'gate'])->findOrFail($id);
@@ -284,21 +284,23 @@ class SupportTimesheetController extends Controller
: null;
$operatingHours = $endMeter !== null ? max(0, $endMeter - $startMeter) : null;
$shift = $validated['shift'] ?: 'Shift Siang';
$timesheetNo = UnitSupportTimesheet::generateTimesheetNo(Carbon::parse($validated['date']));
$updaterName = auth()->user()?->name ?? 'Admin QMA';
$timesheetNo = null;
DB::transaction(function () use (
$validated,
$vehicle,
$operator,
$timesheetNo,
$startMeter,
$endMeter,
$operatingHours,
$shift,
$updaterName
$updaterName,
&$timesheetNo
) {
// Generate nomor timesheet unik di dalam transaksi untuk meminimalkan bentrokan
$timesheetNo = UnitSupportTimesheet::generateTimesheetNo(Carbon::parse($validated['date']));
// 1. Simpan Data Timesheet Heavy Equipment
$timesheet = UnitSupportTimesheet::create([
'timesheet_no' => $timesheetNo,
@@ -67,6 +67,20 @@ class StoreVehicleActivityRequest extends FormRequest
// 1. Validasi SIMPER Pengemudi (BR-01 & BR-02)
$driver = Employee::find($this->input('driver_id'));
if ($driver) {
// Proteksi IDOR: Karyawan biasa tidak boleh memalsukan perjalanan atas nama karyawan lain yang memiliki akun sendiri
$user = $this->user();
if ($user) {
$userEmployee = $user->getOrCreateEmployee();
$isStaffAdmin = $user->isSuperAdmin() || $user->isPgAdmin() || $user->isGateOfficer() || $user->isHseAdmin() || $user->isQmaAdmin();
if (!$isStaffAdmin && $userEmployee && $driver->id !== $userEmployee->id && !empty($driver->user_id) && $driver->user_id !== $user->id) {
$validator->errors()->add(
'driver_id',
"Akses Ditolak: Anda tidak diizinkan mencatatkan aktivitas kendaraan atas nama karyawan lain ({$driver->name}). Gunakan akun pribadi Anda."
);
return;
}
}
if (!$driver->is_operator) {
$validator->errors()->add(
'driver_id',